Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add whenKeyExists method #32663

Closed
wants to merge 1 commit into from
Closed

[7.x] Add whenKeyExists method #32663

wants to merge 1 commit into from

Conversation

emargareten
Copy link
Contributor

This PR adds a method which allows filtering JsonResource to include only queried fields. e.g. when query has the select()/addSelect() methods or when specifying the columns in get() or paginate().

see #32662

@GrahamCampbell GrahamCampbell changed the title add whenKeyExists method [7.x] Add whenKeyExists method May 3, 2020
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@laserhybiz
Copy link

Implemented in #45376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants