Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix missing statement preventing deletion #33648

Merged
merged 2 commits into from
Jul 27, 2020
Merged

[6.x] Fix missing statement preventing deletion #33648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c3c5fd
Fix missing statement preventing deletion
lukadriel7 Jul 25, 2020
c89027d
style change
lukadriel7 Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Illuminate/Database/Eloquent/Relations/MorphPivot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ protected function setKeysForSaveQuery(Builder $query)
*/
public function delete()
{
if (isset($this->attributes[$this->getKeyName()])) {
return (int) parent::delete();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this cast needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, To be honest, I don't know.
I just took the code from the laravel 7.x branch since the use case worked there.

MorphPivot Laravel 6.x

MorphPivot Laravel 7.x

}

if ($this->fireModelEvent('deleting') === false) {
return 0;
}
Expand Down