[7.x] AuthenticateSession Multi Guard support #33885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a BC break. It'll break apps for users currently using that part of the app, on deployment. |
|
Laravel 8 will be out soon anyway. :) |
|
@GrahamCampbell This is not a BC, because have only key name is changed. This is not a BC. |
|
It is breaking, because suppose the old key is used, then the update is rolled out, and the new code doesn't use it now. |
|
It doesn't make sense to make unnecessary breakages in Laravel 7, when Laravel 8 is so close to being released. |
|
@GrahamCampbell Already, SESSION_LIFETIME=120 in default enviroment file. Okay. 🕺 I'm impatient. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here haven't a BC. Actually, this PR is a bug fix.
Solves conflict when working on multi guard.
Related: #33876