Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add new Pipeline::setContainer method #34343

Merged
merged 1 commit into from
Sep 15, 2020
Merged

[8.x] Add new Pipeline::setContainer method #34343

merged 1 commit into from
Sep 15, 2020

Conversation

ryangjchandler
Copy link
Contributor

@ryangjchandler ryangjchandler commented Sep 15, 2020 •
edited
Loading

This pull request adds a new Pipeline::setContainer(Container $container) method that allows setting the container instance after initial instantiation of the Pipeline class, useful since the $container argument in the constructor is nullable / not required so it only makes sense to allow setting it after instantiation.

@ryangjchandler
Copy link
Contributor Author

Thanks for approving @driesvints <3

@taylorotwell taylorotwell merged commit e6199a4 into laravel:8.x Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryangjchandler @driesvints @taylorotwell