[8.x] Fix Client\Response throw
method
#34597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34591
Commit d034e2c changed the
Illuminate\Http\Client\Response@throw
method to accept an optional callback. But code started failing when thethrow
method was being called without any parameters.According to PHP docs on
func_get_arg
https://www.php.net/manual/en/function.func-get-arg.phpThis PR fixes that by changing that statement to
$callback = func_get_args()[0] ?? null
.While testing locally I noticed the same commit also created an
$exception
variable inside aif
block and throw it outside. In the case a$callback
was not provided the code would fail due to a undefined$exception
variable. This PR addresses that case too.