[8.x] Remove expectedTables after converting to expectedOutput in PendingCommand #35163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the newly added method
expectsTable
inIlluminate\Testing\PendingCommand
leads to errors if other commands, without the expected table output, run after the command with the expected table output within the same test.For example:
This leads to a failed test, because the table output of the first command is expected for the second command too.
The problem is, that for every command that runs in a test, the expected tables in the test get converted to expected output again.
I just removed the expected table after converting it so it will be used just once.