New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Revert "[8.x] Make Validator::parseNamedParameters public" #35194

Closed

GrahamCampbell wants to merge 1 commit into 8.x from revert-35183-public-parsing-of-named-params

Member

GrahamCampbell commented Nov 12, 2020

Reverts #35183. Should be made in 9.x only. It is likely some people are overriding this method, and changing its visibility is breaking.


          Revert "Make praseNamedParameters public (#35183)"

This reverts commit c26bbea.

Member

taylorotwell commented Nov 12, 2020

I'm not sure people are overriding this method. Overriding it would literally break validation parameter parsing for all pieces of the framework.

taylorotwell closed this

driesvints deleted the revert-35183-public-parsing-of-named-params branch

November 12, 2020 13:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet