[9.x] Allow for accessing cookies via TestResponse #35611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestResponse::getCookie()
is currently protected, and is only used internally for cookie assertions. This PR exposes this method and handles the decryption of cookies.This is particularly useful if a cookie has an unpredictable value which is needed later in your test.
Before:
After:
It's worth noting that
TestResponse::getCookie()
already exists and is used almost exactly like the "Before" use-case. This simply makes that functionality available to application tests, and adds framework tests for it.This also adds a bunch of test cases for cookie assertions, which were missing before.
In one test I discovered a bug which I can also submit as a separate PR to 8.x. Right now
assertCookieNotExpired()
doesn't properly handle "session" cookies (i.e. cookies where the expiration is0
). This PR fixes that bug and adds a test for it.