[8.x] Clear a cached user in RequestGuard if a request is changed #35692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guard retrieves a user from a request data, so a cached user should be cleared on a request change.
GrahamCampbell
changed the title
|
@taylorotwell @GrahamCampbell This breaks the Passport::actingAs method, thus breaking all tests using Passport. |
taylorotwell
added a commit
that referenced
this pull request
Dec 22, 2020
|
We reverted this |
|
I'm actually a bit confused because without this change it's not possible to test Sanctum logout and/ or token refresh properly. See https://laracasts.com/discuss/channels/testing/tdd-with-sanctum-issue-with-user-logout-case?page=1&replyId=797893 |
|
This change still makes sense to me, but I don't remember any details why I didn't continue with it. Looks like there is a bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guard retrieves a user based on a request data, so a cached user should be cleared on a request change.
Personally, I've faced a problem with it while creating a test for my API with a help of default Laravel testing methods (
postJson,getJsonetc). Requests with different API tokens got the same user (from the first request) because it is cached which is counter-intuitive.