[8.x] "null" constraint prevents aliasing SQLite ROWID #35792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SQLite, columns are nullable by default. Adding
null
forcibly, prevents users aliasingROWID
and will create another (autoincrementing in some cases) column and it's overhead in calculation (see: SQLite ROWID and the INTEGER PRIMARY KEY)To summerize SQLite documentation: by default, every table has a
rowid
column, which already is an INTEGER (64bits), is autoincrementing (not always by 1) and is unique across the table. When a column type is exactlyINTEGER
and aPRIMARY KEY
, then this column is an alias ofrowid
. When the column type isINTEGER NULL
,INT
,BIGINT
or anything else, it's a totally different column.This change should be backward compatible as columns are nullable by default anyway.