Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix issue with dumping schema from a postgres database using no default schema #35966

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

emiliopedrollo
Copy link
Contributor

@emiliopedrollo emiliopedrollo commented Jan 20, 2021

This PR solves the issue #35965 by adding the schema of the table to be ignored in the --exclude-table-data option when performing a dump.

When loading generated dump it outputs some warnings saying that it cannot create the schema because it already exists, either way the rest of the load works successfully. Looking into the Postgresql documentation it is possible tho suppress such warnings ugins the option --clean and --if-exists when executing a pg_restore. As the load will only occur when the database is empty anyway the addition of those options seems harmless.

Fixes #35965

@GrahamCampbell GrahamCampbell changed the title Fix issue with dumping schema from a postgres database using no default schema [8.x] Fix issue with dumping schema from a postgres database using no default schema Jan 20, 2021
@taylorotwell taylorotwell merged commit 97f6f21 into laravel:8.x Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants