Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add commonmark as recommended package for Illuminate\Support #36171

Merged
merged 1 commit into from
Feb 8, 2021
Merged

[8.x] Add commonmark as recommended package for Illuminate\Support #36171

merged 1 commit into from
Feb 8, 2021

Conversation

timacdonald
Copy link
Member

league/commonmark is a required package when using the Str::markdown() and $stringable->markdown() methods.

illuminate/support when used outside of laravel/framework does not require league/commonmark in it's composer.json.

Added as a suggested package, which seems to be the home for others like this, such as ramsey/uuid.

PR that introduced of these methods: #36071

@GrahamCampbell
Copy link
Member

Is this missing on 6.x?

@timacdonald
Copy link
Member Author

timacdonald commented Feb 8, 2021

Is this missing on 6.x?

I've just checked 6.x and 7.x and neither of them have this in their composer.json, however these markdown method were only added to 8.x, so unless there was another reason for it to exist in the previous versions, I think that makes sense...unless I'm misunderstanding the question.

Let me know. Happy to make any required tweaks.

@driesvints
Copy link
Member

It's only needed for 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants