[8.x] Allow using dot syntax for $responseKey #36196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the
assertJsonMissingValidationErrors()
assertion does not appreciate the dot syntax of the$responseKey
parameter. However, theassertJsonValidationErrors()
assertion appreciates that.So if we had a Laravel project with a customised way of exposing JSON validation errors as something like this:
the following test would pass:
So, this PR makes it so it appreciates the dot syntax for the
$responseKey
parameter on theassertJsonMissingValidationErrors()
assertion as it's partially related assertionassertJsonValidationErrors()
appreciates that.