[8.x] Allow users to specify configuration keys to be used for primitive binding #36241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntactic sugar around fancy calls to
->give()
related to getting primitives from configuration.Most of the time when I'm doing primitive binding it is for the purpose of using configuration values as constructor arguments. A lot of function calls are used and feel pretty bulky compared to being able to just say, "hey, get the value from this config key."
This PR provides the ability to do just that. Need an API key?
->need('$apiKey')->giveConfig('awesome_api.key')
is all you'd need to set in a service provider now.Is the same as:
and
I believe this may require additional work on the contract (?) that I'll do if this gets approved. Would just need to know which branch to target that change on. I can also do the docs on this if it looks like this will be able to be merged. :)