Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] The label for page number in pagination links should always be a string #36292

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

smujaddid
Copy link
Contributor

For the consistency, the label for page number in pagination links generated by LengthAwarePaginator class should always be a string instead of mix of string and number.

@smujaddid smujaddid changed the title The label for page number in pagination links should always be a string [8.x] The label for page number in pagination links should always be a string Feb 17, 2021
@taylorotwell taylorotwell merged commit 3c89871 into laravel:8.x Feb 17, 2021
@smujaddid smujaddid deleted the label-always-as-string branch February 22, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants