[8.x] Fix retry command for encrypted jobs #36334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new
Illuminate\Contracts\Queue\ShouldBeEncrypted
interface on a job if you run thephp aritsan queue:retry
command you get the following error:unserialize(): Error at offset 0 of x bytes
This is because the job's command is not decrypted before being unserialized.
Steps to reproduce:
ShouldBeEncrypted
interface$this->fail()
inside the jobphp artisan queue:retry <job-id>
This pull request fixes the issue by checking if the payload's command is encrypted before trying to unserialize it.
The code is taken from the
getCommand(array $data)
method inIlluminate\Queue\CallQueuedHandler.php