-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Add new Stringable::test
method
#36462
Merged
taylorotwell
merged 4 commits into
laravel:8.x
from
ryangjchandler:feature/str-matches-function
Mar 4, 2021
Merged
[8.x] Add new Stringable::test
method
#36462
taylorotwell
merged 4 commits into
laravel:8.x
from
ryangjchandler:feature/str-matches-function
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realise now that |
Yeah, maybe |
@taylorotwell All done. 🤟 |
ryangjchandler
changed the title
[8.x] Add new
[8.x] Add new Mar 4, 2021
Stringable::matches
methodStringable::test
method
Can we have it on |
This was referenced Mar 11, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
Stringable::test
method that checks whether the string matches a particular pattern, but doesn't return the match(es).This is essentially just a shortcut for
$stringable->match('//')->isNotEmpty()
but something that I do often enough, and also macro, that it warranted a pull request to the core.