Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Make ResponseSequence macroable #36719

Merged
merged 2 commits into from
Mar 24, 2021
Merged

[8.x] Make ResponseSequence macroable #36719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cf0eb9
make ResponseSequence macroable
SjorsO Mar 23, 2021
9ee841c
cs
SjorsO Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Illuminate/Http/Client/ResponseSequence.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

namespace Illuminate\Http\Client;

use Illuminate\Support\Traits\Macroable;
use OutOfBoundsException;

class ResponseSequence
{
use Macroable;

/**
* The responses in the sequence.
*
Expand Down
10 changes: 10 additions & 0 deletions tests/Http/HttpClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Illuminate\Http\Client\Request;
use Illuminate\Http\Client\RequestException;
use Illuminate\Http\Client\Response;
use Illuminate\Http\Client\ResponseSequence;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use OutOfBoundsException;
Expand Down Expand Up @@ -802,4 +803,13 @@ public function testCanDump()

VarDumper::setHandler(null);
}

public function testResponseSequenceIsMacroable()
{
ResponseSequence::macro('customMethod', function () {
return 'yes!';
});

$this->assertSame('yes!', $this->factory->fakeSequence()->customMethod());
}
}