[8.x] Fix undefined array key in SqlServerGrammar when using orderByRaw #37859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the exception
which is triggered when using
orderByRaw
after the latest changes to theSqlServerGrammar
.A bit of background (and please correct me if I'm wrong):
When using
Builder::orderBy($column, $direction)
, anorder
is added with keyscolumn
anddirection
(line 1986+):framework/src/Illuminate/Database/Query/Builder.php
Lines 1970 to 1992 in 855a919
When using
Builder::orderByRaw($sql)
, anorder
is added with keystype
andsql
(line 2051):framework/src/Illuminate/Database/Query/Builder.php
Lines 2045 to 2054 in 855a919
Because of this, the patched code currently fails with an exception.