[8.x] Ability to return the default value of a request whenHas and whenFilled methods #38060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times I needed to return the default value using one of the
whenHas
orwhenFilled
methods, but I could not which was annoying because such a great method was practically useless in some cases.The solution taken from the collection, we have there for example the
whenEmpty
method, which takes a paramter that returns the default value.Let's see how this is used in collections:
In the same way now it would be possible to obtain in the request object:
If we do not pass the default value, we will get an instance of the request class, which is the same as before the changes I made.
If I was the only person who needed this solution, then PR is to close.
I also added tests and I hope that I considered each case, I tried to test the introduced code so that it does not force changes on existing solutions.