[8,x] Share handler instead of client between requests in pool to ensure ResponseReceived events are dispatched in async HTTP Request #38380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ResponseReceived events is not dispatched in async HTTP Request
This is beacause PendingRequest::$request is not set and following if statement not passes.
framework/src/Illuminate/Http/Client/PendingRequest.php
Line 994 in 3591526
PendingRequest::$request is set in the handler given to guzzle client.
All requests in Pool use shared Pool::$client and the handler in the Pool::$client set request to the PendingRequest instance which created in the initialization of Pool::$client
not each PendingRequest instances created in Pool::asyncRequest().
To fix this, each request share handler instead of client in this PR.