[8.x] Dispatch events when maintenance mode is enabled and disabled #38826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Sep 15, 2021
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
…aravel#38826) * Add event classes * Add tests * Dispatch events when maintenance mode is enabled and disabled * Remove empty constructors from event classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature makes it easy to trigger actions when the application is put into, or taken out of, maintenance mode.
I found myself wanting this today when setting up monitoring with OhDear.
They have endpoints for
/start-maintenanceand/end-maintenanceand will not send notifications about the site being down during this period.If this PR is merged, I could listen for the events in my application and automatically ping my monitoring service when going in or out of maintenance mode. Or log it, or any action that users see fit.
I tried to follow conventions, but if anything is in the wrong place, or should have better names; just comment and I'll fix it, or feel free to refactor and push changes.
Thanks!