[8.x] - fix for custom date castable and database value formatting #38994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See laravel#38828 and laravel#38720
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
…aravel#38994) * add tests See laravel#38828 and laravel#38720 * update test to pass against current framework * use correct carbon instance types * add custom datetime back to isDateCastable See #388828, laravel#38720 * use underlying Carbon * assign strings instead of Carbon instances * check for custom datetime format only when comparing equivalence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #38720 and #38828.
Instead of always treating
custom_datetimeandimmutable_custom_datetimecasts asisDateCastable(), this only checks them in theoriginalIsEquivalent()method.This retains the old behavior for formatting values for the database, while incorporating a fix to ensure that custom (immutable) date casts are compared correctly, even if the Carbon instance is not identical.