Remove deprecated password validation rule #39030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37650 the
password
rule was renamed tocurrent_password
with the intention of removing the old rule in the next major version. This PR removes it.The original reasoning behind this was that later
password
could be used as an alias for the newPassword::defaults()
while I'm still supporting the idea I'm not sure whether it should be done in the next version or in a later one.The problem with implementing it right away is that it can pass for the provided password even if it's not valid for developers who does not follow the upgrade guide. By waiting a few minor or even a major version we could prevent security issues because it would simply throw an exception.
If it should be included in this version I'm willing to create a pull request for it.