[8.x] Add a way to skip count check but check $callback at the same time for AssertableJson->has() #39224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR introduces a feature to AssertableJson->has() to skip the count check but check the third argument $callable
(might be a bug?)
Details
Currently the
->has()
method ofsrc/Illuminate/Testing/Fluent/AssertableJson.php
has a shorthand syntax where you can write:instead of:
but this syntax doesn't support where you don't want to assert the length but want to check the first item.
such as:
This PR removes the check of
$length
to get into the if clause to call$callback
and instead dynamically decide whether to put->count($length)
or not, enabling what's trying to be done above.