Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[8.x] Add gate policy callback" #39290

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Revert "[8.x] Add gate policy callback" #39290

merged 1 commit into from
Oct 21, 2021

Conversation

driesvints
Copy link
Member

Reverts #39185

@cbl
Copy link
Contributor

cbl commented Oct 21, 2021

Is it really necessary to revert the complete pr? I think it is fine to only revert the changes regarding the AuthorizesRequests trait.

@driesvints
Copy link
Member Author

@cbl if you can submit a PR with a fix before this one gets merged I'll close my PR 👍

@taylorotwell taylorotwell merged commit dade8df into 8.x Oct 21, 2021
@taylorotwell taylorotwell deleted the revert-39185-feat/gate-callback branch October 21, 2021 13:04
@driesvints
Copy link
Member Author

@cbl Taylor already merged this one. It's best that you attempt again without the breaking changes.

@driesvints driesvints mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @cbl @taylorotwell