[9.x] Use Relative View Path Name When Hashing Compiled Views #39642
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are not able to "pre-compile" views on say a local machine/build box, and push it into prod "pre-compiled". This is because the filename of the cached view is a sha1 of the absolute path of the file. Meaning, if the directory is different on which the view was initially compiled, then the view is then recompiled.
This PR introduces a new
basePath
param into the the Compiler - which then allows us to take the absolute path of the view, and remove the base path from it - which is then used as the "name" before being hashedTargeted into 9.x as this is a possible breaking change.
Driver behind this was during a vapor deploy, we can pre-compile the views (locally) into bootstrap/cache/views and serve them already compiled. Which is great for a read-only filesystem.