[8.x] Use parents to resolve middleware priority #39647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when middlewares are ordered it uses the class name and its interfaces for sorting but not it's parents.
This is a problem for example in Jetstream because:
AuthenticateSession
middleware with it's own.Authenticate
middlewareThis PR fixes this behaviour by using parent classes for ordering so the Jetstream
AuthenticateSession
middleware will be in the correct place because it extends the LaravelAuthenticateSession
middleware.I also added test for the parent sorting and the already present interface sorting.