[8.x] Pusher 6.x+ does not support TLS options anymore #39920
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Pusher 6.x+ swapped their support from CURLOPT to Guzzle, and removed the TLS options, and this brought a series of issues for TLS users that use self-signed certs in servers like Laravel WebSockets and soketi, locally or in private networks.
Potential fixes
There may be an approach to fix this by overwriting the
BroadcastManager
class at bootstrapping, but I had to find a way to overcome this by solving it at the root so that it isn't required.Along the way, pre-6.x Pusher support has to be deprecated, and this might lead to issues in 8.x and should be in 9.x, but at the same time, it should be seen as a fix to support the new Pusher version's client argument.
This PR initializes Pusher with a Guzzle client whose options are defined in
config/broadcasting.php
.curl_options
are no longer used, so in case it's defined, it should be removed: