[8.x] Fix Str::headline/Str::studly with unicode and add Str::ucsplit method #40499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylorotwell I feel that this should target |
|
@stevebauman i found a issue with headline method: Str::headline('Year 2022')the result is |
|
@foremtehan I'm not able to reproduce this with this new patch: // Displays: "Year 2022"
echo Str::headline('Year 2022'); |
|
Look like it will be fix via this PR, I'm on v8.77.1 and this method has that issue. |
|
You're right I'm able to reproduce that as well on v8.x. I've just added some extra assertions so we can ensure this bug is resolved 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues with unicode characters mentioned in issue #40468, fixing
Str::headline()andStr::studly().I've also added another
Strhelper functionucsplit()to split a string based on casing, which is compatible with english and unicode characters. This new function is used byStr::headline(), to help with parsing strings that do not contain spaces.All previous tests pass and there are no BC breaks 🎉
Let me know if you have any concerns/questions, thanks for your time! ❤️