[8.x] Improve PhpRedis flushing #40544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translate Predis syntax to PhpRedis' `true` parameter
derekmd
reviewed
Jan 21, 2022
tillkruss
changed the title
|
I know nothing of the internals here so I'm not the right person to review this. |
TheLevti
reviewed
Jan 23, 2022
|
|
||
| foreach ($this->client->_masters() as $master) { | ||
| $this->client->flushDb($master); | ||
| if (strtoupper((string) $arguments[0] ?? null) === 'ASYNC') { |
There was a problem hiding this comment.
This causes a lot of tests to fail for me with an index access that does not exist.
It should be if (strtoupper((string) ($arguments[0] ?? null)) === 'ASYNC') {
There was a problem hiding this comment.
As sometimes there are no arguments at all and the string cast takes precedence.
There was a problem hiding this comment.
I'll make a PR with tests and the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #40446 to make PhpRedis connections behave like Predis as usual.
PhpRedisClusterConnectionASYNCmodifier to both PhpRedisflushdb()methodsPhpRedisClusterConnection::flushdb()will now fireCommandExecutedevents as well