Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Return collection from ucsplit #40699

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[8.x] Return collection from ucsplit #40699

merged 1 commit into from
Jan 28, 2022

Conversation

tomirons
Copy link
Contributor

As suggested in my previous PR (#40694), other methods like explode return a collection, so why not this one?

@taylorotwell taylorotwell merged commit b12f44c into laravel:8.x Jan 28, 2022
@tomirons tomirons deleted the patch-3 branch January 28, 2022 16:32
@buismaarten
Copy link
Contributor

Isn't this a breaking change on 8.x?

@driesvints
Copy link
Member

@buismaarten this method was broken (see the other PR) so this wasn't working in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomirons @buismaarten @driesvints @taylorotwell