[9.x] Add filtering of route:list by domain #40970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure doesn't seem to have anything to do with this PR. |
GrahamCampbell
changed the title
|
@Synchro, you can also try |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to the discussion in #40815, I have broken out the domain filtering part. It's a very simple addition that lets you filter the route list by domain, much as you can for paths:
The only other change is a minor cleanup to make all the filtering options use the same syntax (without any functional changes), as it was inconsistent and potentially ambiguous, causing it to be flagged by static analysis tools.