Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Add method to AwsS3V3Adapter #41079

Merged
merged 2 commits into from
Feb 17, 2022
Merged

[9.x] Add method to AwsS3V3Adapter #41079

merged 2 commits into from
Feb 17, 2022

Conversation

dododedodonl
Copy link
Contributor

@dododedodonl dododedodonl commented Feb 17, 2022

Make it convenient to retrieve the client of \Illuminate\Filesystem\AwsS3V3Adapter, like getDriver() or getAdapter() of \Illuminate\Filesystem\FilesystemAdapter

@dododedodonl dododedodonl changed the title Add method to AwsS3V3Adapter [9.x] Add method to AwsS3V3Adapter Feb 17, 2022
@taylorotwell taylorotwell merged commit d649c09 into laravel:9.x Feb 17, 2022
@keironlowe-edriving
Copy link

Could someone clarify how we use this? When I use Storage::disk('s3')->getAdapter() it returns an instance of League\Flysystem\AwsS3V3\AwsS3V3Adapter, not Illuminate\Filesystem\AwsS3V3Adapter.
Thanks

@dododedodonl
Copy link
Contributor Author

Storage::disk('s3') already returns Illuminate\Filesystem\AwsS3V3Adapter, ->getAdapter() returns the underlying flysystem adapter.

@keironlowe-edriving
Copy link

@dododedodonl Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants