Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Redesign php artisan schedule:list Command. #41445

Merged
merged 17 commits into from
Mar 12, 2022
Merged

[9.x] Redesign php artisan schedule:list Command. #41445

merged 17 commits into from
Mar 12, 2022

Conversation

xiCO2k
Copy link
Contributor

@xiCO2k xiCO2k commented Mar 11, 2022

This PR Improves the look for the php artisan schedule:list command.

The design was heavily inspired by the new version of the route:list.

Before:

image

After

image

Also there is available a verbose mode that will show the full cli path, *raw dates and description.

Verbose Mode

image

Cheers,
Francisco

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Mar 11, 2022

Looks like the $this->artisan(ScheduleListCommand::class, ['-v' => true]) is interfering with RouteListCommandTest. maybe it need to be set as default to OutputInterface::VERBOSITY_NORMAL.

Thoughts?

@taylorotwell
Copy link
Member

@xiCO2k ready now?

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Mar 12, 2022

Yep

@taylorotwell taylorotwell merged commit d13c348 into laravel:9.x Mar 12, 2022
@taylorotwell
Copy link
Member

Thanks for your work on this! ❤️

@xiCO2k xiCO2k deleted the feat/redesign-schedule-list branch March 12, 2022 01:28
@flightsupport
Copy link

I think scheduled jobs should be visible without having to set the -v flag.
With many scheduled jobs, the output is not meaningful.

Output without -v
*/5 * * * * ................................................................. Next Due: 3 minutes from now

Output with -v

*/5 * * * *  .................................................. Next Due: 2022-03-15 20:35:00 +00:00
               ⇁ App\Jobs\ShiftSupervisor

@driesvints
Copy link
Member

@flightsupport please see #41494

@xiCO2k
Copy link
Contributor Author

xiCO2k commented Mar 15, 2022

It is not that much clear a Job, but I will think on a way to show the job correctly like a command schedule. Thanks for pointing that out @flightsupport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants