Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix #41302 #41546

Merged
merged 2 commits into from
Mar 18, 2022
Merged

[9.x] Fix #41302 #41546

merged 2 commits into from
Mar 18, 2022

Conversation

xrobau
Copy link
Contributor

@xrobau xrobau commented Mar 17, 2022

This is an alternative option to PR #41502, and adds a match
for 'socket' ("socket error when (reading|writing)") to trigger
a reconnection.

I am not sure if this check is valid in other languages.

My personal preference would be to remove the entire if and
ALWAYS reconnect on any Exception

Signed-Off-By: Rob Thomas xrobau@gmail.com

This is an alternative option to PR laravel#41502, and adds a match
for 'socket' ("socket error when (reading|writing)") to trigger
a reconnection.

I am not sure if this is valid in other languages, too.

My personal preference would be to remove the entire if and
ALWAYS reconnect on any Exception

Signed-Off-By: Rob Thomas xrobau@gmail.com
@taylorotwell taylorotwell merged commit 4d770fd into laravel:9.x Mar 18, 2022
@GrahamCampbell GrahamCampbell changed the title Bugfix #41302 - Alternative [9.x] Fix #41302 Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants