[9.x] Fix afterCommit and RefreshDatabase #41782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using the
RefreshDatabase
trait was fundamentally incompatible withafterCommit
. This is because the trait is based around the fact that it opens a transaction and rolls it back at the end of the test, never committing it.This slight modification updates the
DatabaseTransactionManager
to "ignore" a given transaction when determining if a callback should be executed, since we want the outer transaction to essentially be invisible.Would appreciate some feedback on if this solves people's problems and / or creates new problems.
Fix #35857