[9.x] Fixes applying replacements to multi-level localization arrays #42022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the localization parameters replacement when retrieving a multi-level localization array.
Back on 5.7 (#27254) this was fixed for single-level arrays, but it fails if you are retrieving something with more levels because
makeReplacements
function expects a string, not an array.For example, currently this will fail:
Translation file
lang/en/foo.php
:This solution walks all the values recursively in the array case instead of just looping on the first-level array.