[9.x] Allow forcing requests made via the Http client to be faked

src/Illuminate/Http/Client/Factory.php

@@ -94,6 +94,13 @@ class Factory
      */
     protected $responseSequences = [];
 
+    /**
+     * Indicates that an exception should be thrown if any request is not faked.
+     *
+     * @var bool
+     */
+    protected $preventStrayRequests = false;
+
     /**
      * Create a new factory instance.
      *
@@ -220,6 +227,29 @@ public function stubUrl($url, $callback)
         });
     }
 
+    /**
+     * Indicate that an exception should not be thrown if any request is not faked.
+     *
+     * @param  bool  $prevent
+     * @return $this
+     */
+    public function preventStrayRequests($prevent = true)
+    {
+        $this->preventStrayRequests = $prevent;
+
+        return $this;
+    }
+
+    /**
+     * Indicate that an exception should not be thrown if any request is not faked.
+     *
+     * @return $this
+     */
+    public function allowStrayRequests()
+    {
+        return $this->preventStrayRequests(false);
+    }
+
     /**
      * Begin recording request / response pairs.
      *
@@ -390,7 +420,7 @@ public function __call($method, $parameters)
         }
 
         return tap($this->newPendingRequest(), function ($request) {
-            $request->stub($this->stubCallbacks);
+            $request->stub($this->stubCallbacks)->preventStrayRequests($this->preventStrayRequests);
         })->{$method}(...$parameters);
     }
 }

src/Illuminate/Http/Client/PendingRequest.php

@@ -20,6 +20,7 @@
 use Illuminate\Support\Traits\Macroable;
 use JsonSerializable;
 use Psr\Http\Message\MessageInterface;
+use RuntimeException;
 use Symfony\Component\VarDumper\VarDumper;
 
 class PendingRequest
@@ -138,6 +139,13 @@ class PendingRequest
      */
     protected $stubCallbacks;
 
+    /**
+     * Indicates that an exception should be thrown if any request is not faked.
+     *
+     * @var bool
+     */
+    protected $preventStrayRequests = false;
+
     /**
      * The middleware callables added by users that will handle requests.
      *
@@ -1040,6 +1048,10 @@ public function buildStubHandler()
                      ->first();
 
                 if (is_null($response)) {
+                    if ($this->preventStrayRequests) {
+                        throw new RuntimeException('Attempted request to ['.(string) $request->getUri().'] without a matching fake.');
+                    }
+
                     return $handler($request, $options);
                 }
 
@@ -1123,6 +1135,19 @@ public function stub($callback)
         return $this;
     }
 
+    /**
+     * Indicate that an exception should be thrown if any request is not faked.
+     *
+     * @param  bool  $prevent
+     * @return $this
+     */
+    public function preventStrayRequests($prevent = true)
+    {
+        $this->preventStrayRequests = $prevent;
+
+        return $this;
+    }
+
     /**
      * Toggle asynchronicity in requests.
      *

src/Illuminate/Support/Facades/Http.php

@@ -44,6 +44,7 @@
  * @method static \Illuminate\Http\Client\Response post(string $url, array $data = [])
  * @method static \Illuminate\Http\Client\Response put(string $url, array $data = [])
  * @method static \Illuminate\Http\Client\Response send(string $method, string $url, array $options = [])
+ * @method static \Illuminate\Http\Client\Factory allowStrayRequests()
  * @method static void assertSent(callable $callback)
  * @method static void assertSentInOrder(array $callbacks)
  * @method static void assertNotSent(callable $callback)
@@ -93,6 +94,18 @@ public static function fakeSequence(string $urlPattern = '*')
         return $fake->fakeSequence($urlPattern);
     }
 
+    /**
+     * Indicate that an exception should be thrown if any request is not faked.
+     *
+     * @return \Illuminate\Http\Client\Factory
+     */
+    public static function preventStrayRequests()
+    {
+        return tap(static::getFacadeRoot(), function ($fake) {
+            static::swap($fake->preventStrayRequests());
+        });
+    }
+
     /**
      * Stub the given URL using the given callback.
      *

tests/Http/HttpClientTest.php

@@ -25,6 +25,7 @@
 use OutOfBoundsException;
 use PHPUnit\Framework\AssertionFailedError;
 use PHPUnit\Framework\TestCase;
+use RuntimeException;
 use Symfony\Component\VarDumper\VarDumper;
 
 class HttpClientTest extends TestCase
@@ -1527,4 +1528,21 @@ public function testRequestExceptionIsNotThrownIfConditionIsNotSatisfied()
 
         $this->assertSame('{"result":{"foo":"bar"}}', $response->body());
     }
+
+    public function testItCanEnforceFaking()
+    {
+        $this->factory->preventStrayRequests();
+        $this->factory->fake(['https://vapor.laravel.com' => Factory::response('ok', 200)]);
+        $this->factory->fake(['https://forge.laravel.com' => Factory::response('ok', 200)]);
+
+        $responses = [];
+        $responses[] = $this->factory->get('https://vapor.laravel.com')->body();
+        $responses[] = $this->factory->get('https://forge.laravel.com')->body();
+        $this->assertSame(['ok', 'ok'], $responses);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Attempted request to [https://laravel.com] without a matching fake.');
+
+        $this->factory->get('https://laravel.com');
+    }
 }

tests/Support/SupportFacadesHttpTest.php

@@ -48,4 +48,11 @@ public function testFacadeRootIsSharedWhenStubbingUrls(): void
         $factory = $this->app->make(Factory::class);
         $this->assertSame('OK!', $factory->get('https://laravel.com')->body());
     }
+
+    public function testFacadeRootIsSharedWhenEnforcingFaking(): void
+    {
+        $client = Http::preventStrayRequests();
+
+        $this->assertSame($client, $this->app->make(Factory::class));
+    }
 }