[9.x] Fix Str::Mask() for repeating chars #42295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjokkateer
changed the title
- Add some additional test cases to verify behaviour for more than 2 repeating characters. - Add some cases for testing the masking from the start of the string, before the start of the string and end of string.
BrandonSurowiec
pushed a commit
to BrandonSurowiec/framework
that referenced
this pull request
Jun 26, 2022
- Add some additional test cases to verify behaviour for more than 2 repeating characters. - Add some cases for testing the masking from the start of the string, before the start of the string and end of string. (cherry picked from commit a917528)
taylorotwell
pushed a commit
that referenced
this pull request
Jun 27, 2022
- Add some additional test cases to verify behaviour for more than 2 repeating characters. - Add some cases for testing the masking from the start of the string, before the start of the string and end of string. (cherry picked from commit a917528) Co-authored-by: Remy Bos <27890746+sjokkateer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Str::mask()does not correctly deal with repeating characters in the$stringargument.One such case is:
Str::mask('maan@email.com', '*', 2, 1)which, before this PR would return the string:'m*an@email.com'.The reason for this behaviour is because in Str::mask() L#498 a call to mb_strpos is made with
$segmentas$needle, where$segmentwould equal'a'. This would return the numeric position of the first occurence, which would equal 1 setting$startequal to the substring'm'and$endto'an@email.com'.After this pull request the same test case results in the string
'ma*n@email.com'while also passing all the original test cases.