Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix TypeError in DeadlockException #42337

Merged
merged 1 commit into from
May 10, 2022
Merged

[9.x] Fix TypeError in DeadlockException #42337

merged 1 commit into from
May 10, 2022

Conversation

Brenneisen
Copy link
Contributor

@Brenneisen Brenneisen commented May 10, 2022 •
edited
Loading

Fixes #42317.

@driesvints
Copy link
Member

Like I said before, this doesn't seems the correct solution. It seems to me that this is a bug in PHP itself and that the PDOException needs its own constructor.

With this change, you're converting the string code into an integer which probably is wrong.

@Brenneisen Brenneisen changed the title Fix TypeErrpr in DeadlockException Fix TypeError in DeadlockException May 10, 2022
@taylorotwell
Copy link
Member

I believe we have had to do this other places as well in regards to PDO.

@taylorotwell
Copy link
Member

taylorotwell commented May 10, 2022 •
edited
Loading

CleanShot 2022-05-10 at 10 08 05@2x

@taylorotwell taylorotwell merged commit 8aa4173 into laravel:9.x May 10, 2022
@GrahamCampbell GrahamCampbell changed the title Fix TypeError in DeadlockException [9.x] Fix TypeError in DeadlockException May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Brenneisen @driesvints @taylorotwell