[9.x] Implement robust handling of forwarding of exception codes #42393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
reviewed
May 23, 2022
| @@ -706,7 +706,7 @@ public function get(string $id) | |||
| throw $e; | |||
| } | |||
|
|
|||
| throw new EntryNotFoundException($id, $e->getCode(), $e); | |||
| throw new EntryNotFoundException($id, is_int($e->getCode()) ? $e->getCode() : 0, $e); | |||
There was a problem hiding this comment.
Couldn't you assign the result of the function call to save calling it twice when it is an int?
Suggested change
| throw new EntryNotFoundException($id, is_int($e->getCode()) ? $e->getCode() : 0, $e); | |
| throw new EntryNotFoundException($id, is_int($code = $e->getCode()) ? $code : 0, $e); |
Appreciate this is a very minor optimisation in this case.
saas786
added a commit
to saas786/hybrid-core
that referenced
this pull request
May 23, 2022
saas786
added a commit
to saas786/hybrid-core
that referenced
this pull request
May 23, 2022
…(#42393) - Sync upto v9.13.0 - illuminate/container@d86b073 - laravel/framework#42393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCode(): string|intbut__construct(..., int $code, ...). The most sensible thing to do is to attempt to only forward on integer exception codes, and just default back to zero, otherwise. String exception codes (at least ignoring janky 3rd party extensions), can only be found amongst the PHP database exceptions, and for those, we should consider the code to be zero for the purposes of forwarding - casting to1doesn't make any sense.