[9.x] Added Eloquent withWhereHas method #42597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of times that we need to load a relationship using
with
with the same conditions that we use forwhereHas
.This method simplifies this selection by avoiding repeating the code used both to filter with
whereHas
and then to select that same record usingwith
. There is less code, it is more readable and easier to maintain.Before
After
If it's ok for you, I will add tests :)