[9.x] Start session in TestResponse to allow marshalling of error bag from JSON
#42710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Jun 8, 2022
Krisell
changed the title
Krisell
changed the title
TestResponse to allow marshalling of error bag from JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
'session.serialization' => 'json'theViewErrorBagcontent is saved as an array and rebuilt when the session data is loaded. InTestResponsethestart()method on the sessionStorewas never called, causing the issue discovered by @tanthammar in #42494This PR adds a
$this->session()->start()call inTestResponseunless the session is already started (i.e. once). The added test fails withError: Call to a member function getBag() on arraywithout the implementation change.Related to #42090 and #40595