Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix Request offsetExists without routeResolver #42754

Merged
merged 3 commits into from
Jun 10, 2022
Merged

[8.x] fix Request offsetExists without routeResolver #42754

merged 3 commits into from
Jun 10, 2022

Conversation

danesteve
Copy link
Contributor

When checking if a request parameter isset without the routeResolver being set we get an error.

Example:

isset((new \Illuminate\Http\Request())['foobar']);
// or
(new \Illuminate\Http\Request())['foobar'] ?? '';

// throws the following error
// PHP Error:  Call to a member function parameters() on null

@danesteve danesteve changed the title fix Request offsetExists without routeResolver [8.x] fix Request offsetExists without routeResolver Jun 10, 2022
@danesteve danesteve changed the title [8.x] fix Request offsetExists without routeResolver [8.x] fix Request offsetExists without routeResolver Jun 10, 2022
@taylorotwell taylorotwell merged commit cd6e76f into laravel:8.x Jun 10, 2022
@danesteve danesteve deleted the fix/request-offset-exists branch June 11, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants