Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Improves queue:work command #43252

Merged
merged 9 commits into from
Jul 18, 2022
Merged

[9.x] Improves queue:work command #43252

merged 9 commits into from
Jul 18, 2022

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Jul 18, 2022 •
edited
Loading

This pull request fixes two things:

  • The first, is when the job class code contains a $this->fail():

In Laravel v9.19.0:
Screenshot 2022-07-18 at 09 17 38

In 9.x-dev:
Screenshot 2022-07-18 at 12 20 06

If this pull request gets merged:
Screenshot 2022-07-18 at 09 18 04

  • The second, is when jobs a requeued to be retried later:

In Laravel v9.19.0:
Screenshot 2022-07-18 at 12 02 56

In 9.x-dev:
Screenshot 2022-07-18 at 12 03 47

If this pull request gets merged:
Screenshot 2022-07-18 at 15 13 14

@nunomaduro nunomaduro requested a review from taylorotwell July 18, 2022 11:21
@nunomaduro nunomaduro marked this pull request as draft July 18, 2022 11:32
@nunomaduro nunomaduro marked this pull request as ready for review July 18, 2022 14:14
@taylorotwell taylorotwell merged commit d425952 into 9.x Jul 18, 2022
@taylorotwell taylorotwell deleted the fix/queue-work-on-fails branch July 18, 2022 21:02
@ReDev1L
Copy link

ReDev1L commented Sep 8, 2022 •
edited
Loading

image
Thats what we got in datadog after this PR

$job->resolveName()

resolves multiline closures.

Those workers shouldnt output anything to console without PSR-3 loggers.

Our loggers stuck in between those logs and we recieve combined strings, becouse you use output->write instead of output->writeln

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nunomaduro @ReDev1L @taylorotwell @StyleCIBot