[9.x] Allow using backed enums as route parameters #43294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using backed enum values as route parameters.
Example/Reasoning
I have a project where I have 2 models, Model1 and Model2. Where Model1 hasMany Model2.
Each Model1 can have one Model2 for each backed enum case. In my DB there is a unique constraint on
model1_idandenum_value.Then I have a route
/model1/{model1}/model2/{model2:enum_value}(scoped).This works fine, except every time I want to generate an URL from a named route I have to specify
$model2->enum_value->valueinstead of just$model2.Breaking changes
I can't think of any, except for if you expect an
Object of class <YourBackedEnum> could not be converted to stringerror. Correct me if I'm wrong tho.