Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix DynamoDB locks with 0 seconds duration #43365

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

lukaszmtw
Copy link
Contributor

@lukaszmtw lukaszmtw commented Jul 22, 2022

I've added a default lock duration of 1 day for DynamoDB locks.

This makes the behavior consistent with DatabaseLock:

protected function expiresAt()
{
return $this->seconds > 0 ? time() + $this->seconds : Carbon::now()->addDays(1)->getTimestamp();
}

Fix #43280

@lukaszmtw lukaszmtw marked this pull request as draft July 22, 2022 11:01
@lukaszmtw lukaszmtw marked this pull request as ready for review July 22, 2022 11:33
@taylorotwell taylorotwell merged commit 9d0dfff into laravel:8.x Jul 22, 2022
@driesvints
Copy link
Member

Thanks @lukaszmtw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants