Add getter and setter for connection in the DatabaseBatchRepository
class
#43869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR adds
setConnection
andgetConnection
methods in theDatabaseBatchRepository
class.Why
In the tenancy package, We are adding support for Laravel job batches which required temporarily replacing the BatchRepository connection with the correct tenant connection and then reverting it back when exiting the tenant context.
The current implementation uses the PHP Reflection class. It would be nice to have these methods in the framework to get rid of the Reflection boilerplate and modify the connection easily.
Wondering how our code would look:
Before
After
Tests
I haven't added tests because, as I said, these are simple changes, not a feature. I'm not sure if we need tests for getters and setters. If still wants me to add tests, please comment, and I'll add them.