[9.x] Allow invokable rules to specify custom messsages #43925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Seems like a clean fix. Tested locally and confirmed.
Thanks @nshiro for the PR ❤️
|
Thank you for reviewing my code.😀 @timacdonald |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Laravel 9.2 we have a simple way to specify a custom message when validating with a rule object. #41145
But it doesn't seem to work with invokable rules.
This PR makes invokable rules to work with #41145.